Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AugPipe #1978

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove AugPipe #1978

wants to merge 4 commits into from

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Apr 3, 2024

The next version of kornia (0.7.3) will contain 2 fixes (kornia/kornia#2846, kornia/kornia#2856) that will allow us to drop AugPipe and have detection only depend on kornia's AugmentationSequential.

@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing trainers PyTorch Lightning trainers datamodules PyTorch Lightning datamodules labels Apr 3, 2024
@adamjstewart
Copy link
Collaborator

How close are we to also removing our custom AugmentationSequential wrapper?

@ashnair1
Copy link
Collaborator Author

ashnair1 commented Apr 3, 2024

How close are we to also removing our custom AugmentationSequential wrapper?

Pretty close actually. If kornia==0.7.3 is released soon, we should be able to fully remove it by next release.

@adamjstewart adamjstewart mentioned this pull request Apr 5, 2024
Merged
@adamjstewart adamjstewart added this to the 0.6.0 milestone Apr 5, 2024
@ashnair1 ashnair1 mentioned this pull request Jun 9, 2024
Merged
@robmarkcole robmarkcole mentioned this pull request Jun 10, 2024
Open
@ashnair1 ashnair1 force-pushed the aug-remove branch 2 times, most recently from a018184 to 3cde2de Compare July 4, 2024 07:08
@robmarkcole
Copy link
Contributor

Noting https://github.com/kornia/kornia/releases/tag/v0.7.3

@adamjstewart
Copy link
Collaborator

@ashnair1 is this waiting on kornia 0.7.4 for something?

@ashnair1
Copy link
Collaborator Author

Yeah #2147 needs to be merged before this and that needs kornia 0.7.4.

@adamjstewart adamjstewart modified the milestones: 0.6.0, 0.7.0 Aug 21, 2024
@robmarkcole
Copy link
Contributor

Note: 0.7.4 will be released by the end of September

@ashnair1 ashnair1 mentioned this pull request Nov 7, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets testing Continuous integration testing trainers PyTorch Lightning trainers
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ashnair1 @adamjstewart @robmarkcole